Fix Debian configuration #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not adding them breaks upstreams configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Al,
Debian uses TWO configuration dirs for nginx (
/etc/nginx/sites-availableAND/etc/nginx/conf.d), and only the former was being included in the main config.This raised an issue when setting upstreams with the
manifests::resource::upstreamdefine, as it writes them to/etc/nginx/conf.d. As it was not being included when runnning on a Debian host, nginx failed to start.As a side efect, all hardcoded paths in the defines can now be handled better (not the best way for my taste, but the best I could find without making extensive changes in the module)
This patches also include a spec test to prevent breaking the main
nginx.conffile with typos.