Skip to content

Conversation

@hahuja2
Copy link
Contributor

@hahuja2 hahuja2 commented Oct 21, 2025

This PR removes all sync queue wrap functions, so that PHP 8+ behavior is consistent with pre-oapi behavior where the root span of the trace should be the entry point of the web transaction that initiated job execution.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Oct 21, 2025

Test Suite Status Result
Multiverse 6/16 passing
SOAK 84/85 passing

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.42%. Comparing base (be8c5c1) to head (d3933a0).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1128      +/-   ##
==========================================
- Coverage   78.44%   78.42%   -0.03%     
==========================================
  Files         193      193              
  Lines       28059    28056       -3     
==========================================
- Hits        22012    22004       -8     
- Misses       6047     6052       +5     
Flag Coverage Δ
agent-for-php-7.2 78.40% <ø> (ø)
agent-for-php-7.3 78.42% <ø> (ø)
agent-for-php-7.4 78.28% <ø> (ø)
agent-for-php-8.0 77.78% <ø> (-0.03%) ⬇️
agent-for-php-8.1 78.09% <ø> (-0.03%) ⬇️
agent-for-php-8.2 77.70% <ø> (-0.03%) ⬇️
agent-for-php-8.3 77.70% <ø> (-0.03%) ⬇️
agent-for-php-8.4 77.72% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hahuja2 hahuja2 marked this pull request as ready for review October 22, 2025 00:15
@hahuja2 hahuja2 changed the title feat(agent): update how sync jobs are handled feat(agent): update how laravel sync jobs are handled Oct 22, 2025
@hahuja2 hahuja2 requested review from lavarou and zsistla October 22, 2025 23:16
@hahuja2 hahuja2 merged commit e1738ac into dev Nov 6, 2025
65 checks passed
@hahuja2 hahuja2 deleted the laravel-sync-queue branch November 6, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants