Limits restify-post-7 tests to < Node 18 as restify throws. #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restify currently attempts to patch Request.prototype.closed which is no-longer valid in Node 18.
bizob2828
approved these changes
Jul 14, 2022
Member
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
We will have to keep an eye on restify and remove this when they release the fix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Release Notes
Links
Details
Restify currently attempts to patch Request.prototype.closed which is no-longer valid in Node 18. This will break our versioned tests as Node 18 is added to CI.
Someone has submitted a PR to start Node 18 support: restify/node-restify#1906