Skip to content

refactor: Updated shim classes to no longer construct specs. #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2024
Merged

refactor: Updated shim classes to no longer construct specs. #2096

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88d2dff
refactor: updated shim classes to no longer construct specs.
bizob2828 Mar 20, 2024
4801de0
chore: addressed feedback on PR review
bizob2828 Apr 1, 2024
a4656eb
chore: updated minimum version of koa instrumentation
bizob2828 Apr 1, 2024
6fc4584
Merge branch 'main' into update-spec-construction
bizob2828 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: addressed feedback on PR review
  • Loading branch information
@bizob2828
bizob2828 committed Apr 1, 2024
commit 4801de08ca1357d53f8fade9f4f586daf2a9b8fc
6 changes: 1 addition & 5 deletions lib/shim/specs/wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,7 @@ class WrapSpec extends SegmentSpec {

/* eslint-disable jsdoc/require-param-description */
/**
* The parameters may be a function; if so, that function is used as the
* wrapper. Otherwise, the parameters must be an object with a `wrapper`
* property set to the function that should be the wrapper.
*
* @param {WrapSpecParams|function} params
* @param {WrapSpecParams} params
*/
constructor(params) {
super(params)
Expand Down
1 change: 0 additions & 1 deletion lib/shim/webframework-shim/middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,6 @@ function wrapNextHandler({ shim, spec, route, args, isErrorWare, isPromise, txIn
}

if (shim.isFunction(spec.next)) {
// TODO: should this be a spec?
const nextDetails = {
route,
wrapNext: spec.next,
Expand Down