Skip to content

chore: Added otel compliant attributes for database spans #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2024
Merged

chore: Added otel compliant attributes for database spans #2173

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
004880f
chore: Added otel compliant attributes for database spans
mrickard Apr 26, 2024
f656ea0
chore: Added truncateExempt flag for port properties, and restored de…
mrickard Apr 30, 2024
707ab6e
chore: Removed db span test assertions that conflicted with new prope…
mrickard Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Added truncateExempt flag for port properties, and restored de… 
…faults that had been stripped from JSDoc declarations

Signed-off-by: mrickard <[email protected]>
  • Loading branch information
@mrickard
mrickard committed Apr 30, 2024
commit f656ea02d099193a55e316d038846e86adc566b9
2 changes: 1 addition & 1 deletion lib/spans/span-event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ class DatastoreSpanEvent extends SpanEvent {
if (attributes.port_path_or_id) {
const address = `${attributes.host}:${attributes.port_path_or_id}`
this.addAttribute('peer.address', address)
this.addAttribute('server.port', attributes.port_path_or_id)
this.addAttribute('server.port', attributes.port_path_or_id, true)
attributes.port_path_or_id = null
}
attributes.host = null
Expand Down
2 changes: 1 addition & 1 deletion lib/spans/streaming-span-event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ class StreamingDatastoreSpanEvent extends StreamingSpanEvent {
if (agentAttributes.port_path_or_id) {
const address = `${agentAttributes.host}:${agentAttributes.port_path_or_id}`
this.addAgentAttribute('peer.address', address)
this.addAgentAttribute('server.port', agentAttributes.port_path_or_id)
this.addAgentAttribute('server.port', agentAttributes.port_path_or_id, true)
agentAttributes.port_path_or_id = null
}

Expand Down