Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: Removed unused express5 feature flag
  • Loading branch information
jsumners-nr committed May 20, 2024
commit ec0853e21724bc8eb12117d0dec539e9205156d5
5 changes: 4 additions & 1 deletion lib/feature_flags.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@

// unreleased flags gating an active feature
exports.prerelease = {
express5: false,
// internal_test_only is used for testing our feature flag implementation.
// It is not used to gate any features.
internal_test_only: false,

promise_segments: false,
reverse_naming_rules: false,
undici_async_tracking: true,
Expand Down
2 changes: 1 addition & 1 deletion test/smoke/index/index.tap.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ test('loading the application via index.js', { timeout: 15000 }, (t) => {
let metric = agent.metrics.getMetric('Supportability/Nodejs/FeatureFlag/await_support/enabled')
t.notOk(metric, 'should not create metric for unchanged feature flags')

metric = agent.metrics.getMetric('Supportability/Nodejs/FeatureFlag/express5/enabled')
metric = agent.metrics.getMetric('Supportability/Nodejs/FeatureFlag/internal_test_only/enabled')
t.ok(metric, 'should create metric for changed feature flags')

function shutdown() {
Expand Down
4 changes: 2 additions & 2 deletions test/smoke/newrelic.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ exports.config = {
enabled: true
},
feature_flag: {
await_support: false,
express5: true
internal_test_only: true,
await_support: false
}
}
3 changes: 2 additions & 1 deletion test/unit/feature_flag.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ const Config = require('../../lib/config')

// please do not delete flags from here
const used = [
'internal_test_only',

'async_local_context',
'await_support',
'cat',
'custom_instrumentation',
'custom_metrics',
'express5',
'express_segments',
'legacy_context_manager',
'native_metrics',
Expand Down