Skip to content

chore: Updated flaky when test #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore: Updated flaky when test #2241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: Updated flaky when test
  • Loading branch information
@jsumners-nr
jsumners-nr committed Jun 4, 2024
commit 2cf11484c32bf7b6783e818255607e4b2877caad
5 changes: 2 additions & 3 deletions test/versioned/when/when.tap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,13 +583,12 @@ test('Promise#yield', function (t) {
})

test('Promise#delay', function (t) {
testPromiseInstanceMethod(t, 3, function (p, name) {
testPromiseInstanceMethod(t, 2, function (p, name) {
const start = Date.now()
return p.delay(100).then(function (x) {
const end = Date.now()
t.same(x, [1, 2, 3, name], name + 'should resolve with original promise')
t.ok(end - start > 98, name + 'should wait close to correct time')
t.ok(end - start < 125, name + 'should wait close to correct time')
t.ok(end - start >= 100, name + 'should delay at least the specified duration')
})
})
})
Expand Down