feat: Added supportability metrics Supportability/Features/Instrumentation/kafkajs/<method> to track when consumer and producer methods are being used
#2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation/kafkajs/<method>` to track when consumer and producer methods are being used
bizob2828
force-pushed
the
supportability-metrics
branch
from
5d25f29 to
64af0bd
Compare
jsumners-nr
approved these changes
Jun 6, 2024
Comment on lines
+21
to
+22
| instrumentConsumer({ shim, kafkajs, recordMethodMetric }) | ||
| instrumentProducer({ shim, kafkajs, recordMethodMetric }) |
Contributor
There was a problem hiding this comment.
I don't know why I enjoy seeing object params pay off, but I do 😄
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most tracking metrics were easy as we already instrumented. For
eachBatchi wrapped it and only log tracking metric. I will add PR to angler to start tracking these metrics.How to Test
Related Issues
Closes #2247