Skip to content

Conversation

@jsumners-nr
Copy link
Contributor

This PR resolves #2243.

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2024

CLA assistant check
All committers have signed the CLA.

@jsumners-nr jsumners-nr force-pushed the issue-2243 branch 2 times, most recently from 1048d44 to 1e788d3 Compare June 14, 2024 14:56
@codecov
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (6c964b2) to head (6794de1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
- Coverage   96.32%   96.27%   -0.06%     
==========================================
  Files         284      284              
  Lines       45178    45230      +52     
==========================================
+ Hits        43518    43543      +25     
- Misses       1660     1687      +27     
Flag Coverage Δ
integration-tests-16.x ?
integration-tests-18.x ?
integration-tests-20.x ?
unit-tests-16.x 89.18% <96.15%> (+<0.01%) ⬆️
unit-tests-18.x 89.16% <96.15%> (+<0.01%) ⬆️
unit-tests-20.x 89.16% <96.15%> (+<0.01%) ⬆️
versioned-tests-16.x 77.59% <100.00%> (-0.04%) ⬇️
versioned-tests-18.x 78.58% <100.00%> (-0.06%) ⬇️
versioned-tests-20.x 78.61% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review June 14, 2024 16:35
Comment on lines +87 to +90
result = this.#body?.messages?.reduce((acc, curr) => {
acc += curr?.content ?? ''
return acc
}, '')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to come back and adjust this. It's not clear to me right now how we should handle multiple messages being sent to the LLM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Claude Message API instrumentation to node

3 participants