Skip to content

Conversation

@amychisholm03
Copy link
Contributor

@amychisholm03 amychisholm03 commented Jul 1, 2024

  • Refactored _processUserErrors, _processTransactionExceptions, and _processTransactionErrors into a single function: _processErrors

Original Ticket:

  • There's a lot of duplication here--for example, in the error-collector, _processUserErrors and _processTransactionExceptions are nearly identical, apart from the property they inspect. _processTransactionErrors behaves only slightly differently. Those three could be collapsed into one processor.
  • First half of this Jira ticket (https://new-relic.atlassian.net/browse/NR-96722)

@amychisholm03 amychisholm03 self-assigned this Jul 1, 2024
@amychisholm03 amychisholm03 requested a review from mrickard July 1, 2024 20:53
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some feedback on JSDoc formatting, and a couple items for consideration, but this is very close to ready.

@amychisholm03 amychisholm03 requested a review from jsumners-nr July 2, 2024 13:43
@amychisholm03 amychisholm03 requested a review from jsumners-nr July 2, 2024 15:47
@amychisholm03 amychisholm03 requested a review from jsumners-nr July 2, 2024 16:38
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're really close. I believe that addressing these comments will finish it off.

@amychisholm03 amychisholm03 requested a review from jsumners-nr July 2, 2024 17:07
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants