Skip to content

test: Fixed recordMiddlewawre benchmark test #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024
Merged

test: Fixed recordMiddlewawre benchmark test #2338

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb150b3
test: Fixed recordMiddlewawre benchmark test
bizob2828 Jul 9, 2024
56fa9c0
chore: updated shim.record methods to construct spec
bizob2828 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: Fixed recordMiddlewawre benchmark test
  • Loading branch information
@bizob2828
bizob2828 committed Jul 9, 2024
commit bb150b32bcc3556cce01eaf954443ffc514c8d26
13 changes: 7 additions & 6 deletions test/benchmark/webframework-shim/recordMiddleware.bench.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const symbols = require('../../../lib/symbols')
const agent = helper.loadMockedAgent()
const contextManager = helper.getContextManager()
const shim = new WebFrameworkShim(agent, 'test-module', './')
const { MiddlewareSpec } = require('../../../lib/shim/specs')
const suite = benchmark.createBenchmark({ name: 'recordMiddleware' })

const transaction = helper.runInTransaction(agent, function (tx) {
Expand Down Expand Up @@ -93,26 +94,26 @@ function getReqd() {
}

function implicitSpec() {
return {}
return new MiddlewareSpec({})
}

function partialSpec() {
return {
return new MiddlewareSpec({
next: shim.LAST,
req: shim.FIRST
}
})
}

function explicitSpec() {
return {
return new MiddlewareSpec({
req: shim.FIRST,
res: shim.SECOND,
next: shim.LAST,
name: 'funcy_name',
params: function (shim, fn, name, args) {
return args[0].params
}
}
})
}

function randomSpec() {
Expand Down Expand Up @@ -144,7 +145,7 @@ function noop() {}

function preOptRecordMiddleware() {
for (let i = 0; i < 1000; ++i) {
let m = randomRecord(randomSpec)
let m = randomRecord(randomSpec())
m = typeof m === 'function' ? m : m.func
for (let j = 0; j < 100; ++j) {
m(getReqd(), {}, noop)
Expand Down