Skip to content

chore: Migrate bunyan, pino, and winston tests to node:test #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 8, 2024
Merged

chore: Migrate bunyan, pino, and winston tests to node:test #2634

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b20995
chore: Migrate `bunyan`, `pino`, and `winston` tests to `node:test`
jsumners-nr Oct 4, 2024
cadc1c6
Apply suggestions from code review
jsumners-nr Oct 4, 2024
88f004d
fix lint errors
jsumners-nr Oct 4, 2024
97190db
Apply suggestions from code review
jsumners-nr Oct 4, 2024
9bb97b0
fix lint errors
jsumners-nr Oct 4, 2024
30c0fff
Apply suggestions from code review
jsumners-nr Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Bob Evans <[email protected]>
  • Loading branch information
@jsumners-nr @bizob2828
jsumners-nr and bizob2828 authored Oct 4, 2024
commit 30c0fff2d5b5d0bd1594e6a5938a0db854212dee
3 changes: 1 addition & 2 deletions test/versioned/bunyan/bunyan.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ const assert = require('node:assert')

const helper = require('../../lib/agent_helper')
const { removeMatchedModules } = require('../../lib/cache-buster')
const { match } = require('../../lib/custom-assertions')
const { LOGGING } = require('../../../lib/metrics/names')
const { makeSink, logStuff, originalMsgAssertion, logForwardingMsgAssertion } = require('./helpers')

Expand Down Expand Up @@ -87,7 +86,7 @@ test('local log decorating', async (t) => {

logStuff({ logger, helper, agent })

match(agent.logs.getEvents(), [], 'should not add any logs to log aggregator')
assert.deepEqual(agent.logs.getEvents(), [], 'should not add any logs to log aggregator')
}
)

Expand Down
Loading