feat(depencenies): ⌚ Add PSR Clock interface as dependency #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Contributor
Author
|
cc @come-nc |
This was referenced Dec 22, 2022
Merged
ChristophWurst
approved these changes
Dec 23, 2022
come-nc
approved these changes
Jan 2, 2023
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Please fix PR name s/Click/Clock/ for posterity
nickvergessen
changed the title
Contributor
Author
Done, thanks for the hint |
Contributor
|
Did we merge this too early? https://github.com/nextcloud-deps/ocp/blob/stable26/composer.json has the dep :s |
Contributor
Author
|
Well not specifically. The problem is I was waiting for the PHP 7.4 drop, then forgot to merge the PR and then didn't want to break OCP anymore afterwards. So yeah, reverting in stable26 should do a trick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not cause issues on the OCP interface extending PSR, similar to the logger
Ref: nextcloud/3rdparty#1262