-
Notifications
You must be signed in to change notification settings - Fork 2
chore: update browserlist configuration for compatibility #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be4c1d2 to
7c4961b
Compare
Signed-off-by: skjnldsv <[email protected]>
7c4961b to
5c75ae7
Compare
|
The new configuration requires support for much older browsers than the previous one, resulting in a large bundle size. @skjnldsv Could you confirm, this was intended?
|
Kind of I guess? |
|
|
Ok from me 👍 |
|
Firefox, Edge and Chrome are the problem there because of old versions, there it should be probably last 5 majors max. Ideally we have a crafted list per Nextcloud release, because that list above is not what we support officially, its missing iOS 15. |
|
So for our current promises about supported platforms the query would probably look like:
But to keep also the support for more used browsers I guess a bit longer query like this makes sense: |
|
"ios 15.6" seems like a bad idea, as we'll have to maintain that number |
ah sorry I was wrong, we updated to 16+ so its probably https://browsersl.ist/#q=baseline+widely+available+with+downstream+and+last+4+major+versions+and+not+dead%0Abaseline+widely+available+with+downstream+and+%3E0.25%25+and+not+dead%0Afirefox+esr The problem with the current one is in my opinion that it adds some browsers that do NOT support baseline widely available that add a lot of bundle size. This happens because of the |
|
Another note:
See: |
|
We transform browserslist manually to esbuild compatible But this also affects oxc and thus rolldown-vite for the future (yet it still supports the esbuild targets so its working currently): https://github.com/oxc-project/oxc-browserslist |
Until we minimise CSS. |
But it also takes esbuild browser targets as per config |
ES version target doesn't properly reflect CSS optimisations... That's why we have a complete browserslist config and not just a single ES year. |
I do not talk about ES version but ESBuild targets: https://esbuild.github.io/api/#target We transform browserslist to esbuild to configure it explicitly. |
|
Why do I feel like you two are going far too deep into that topic... 🙈 |

https://browsersl.ist/#q=defaults%2C+not+op_mini+all%2C+not+dead%2C+Firefox+ESR%2C+baseline+widely+available