-
Notifications
You must be signed in to change notification settings - Fork 2
fix: adjust config to support only active or used browsers #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refine configuration as v3.1.0 introduced a bunch of previously not supported *old* browsers that cause heavily increased bundle sizes. This instead goes back to what 3.0.1 had (>0.25% usage) but also includes new browsers (what 3.1.0 wanted to fix) that are not yet used by >0.25% of users. So we support: - Always Firefox ESR - Browsers (and their forks like Edge) that support "baseline widely available" - If they are new (last 4 major versions) - Or still used by >0.25% of the market - And in both cases are not dead Signed-off-by: Ferdinand Thiessen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That moves back the audience coverage to below 90%, I'm not really ok with that
- https://browsersl.ist/#q=defaults%2C+not+op_mini+all%2C+not+dead%2C+Firefox+ESR%2C+baseline+widely+available
- https://browsersl.ist/#q=baseline+widely+available+with+downstream+and+last+4+major+versions+and+not+dead%2C+baseline+widely+available+with+downstream+and+%3E0.25%25+and+not+dead%2C+firefox+esr
Before: Audience coverage: 92.5 %
After: Audience coverage: 86.9 %
But hat was not was should have been changed with 3.1.0. So this list here is more closer to what we officially support, everything else is either already covered (but not listed because the website there is not that smart) or is just old or forces use to create gigantic bundles. Summary: Revert to 3.0.1 state but add support for modern browsers. |
|
For comparison: But instead of adding support for every browser in between with 0% usage we only add explicit support for:
So I do not think we loose any users, also we now support more browsers than with 3.0.1 which we used for 3 years :) |
Signed-off-by: Ferdinand Thiessen <[email protected]>
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You convinced me 👍

Refine configuration as v3.1.0 introduced a bunch of previously not supported old browsers that cause heavily increased bundle sizes. This instead goes back to what 3.0.1 had (>0.25% usage) but also includes new browsers (what 3.1.0 wanted to fix) that are not yet used by >0.25% of users.
So we support: