feat: Rate-limit image previews #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable5 |
nickvergessen
requested review from
Antreesy and
DorraJaouad
and removed request for
SystemKeeper
Antreesy
reviewed
Nov 1, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Everything apart from rate-limiting looks and works fine 🙈
Contributor
Author
Should be fixed, somehow forgot to return the promise |
Antreesy
approved these changes
Nov 1, 2024
susnux
force-pushed
the
feat/rate-limit-previews
branch
from
c8d2341 to
9d8265d
Compare
Antreesy
reviewed
Nov 4, 2024
| * @param url URL of the image | ||
| */ | ||
| export function preloadImage(url: string): Promise<boolean> { | ||
| const { resolve, promise } = Promise.withResolvers<boolean>() |
Contributor
There was a problem hiding this comment.
https://caniuse.com/?search=promise.withresolvers
Should be polyfilled for now, until it has normal support?
// @ts-expect-error This does not exist outside of polyfill which this is doing
if (typeof Promise.withResolvers === 'undefined') {
if (window)
// @ts-expect-error This does not exist outside of polyfill which this is doing
window.Promise.withResolvers = function () {
let resolve, reject
const promise = new Promise((res, rej) => {
resolve = res
reject = rej
})
return { promise, resolve, reject }
};
}
Contributor
Author
There was a problem hiding this comment.
it has normal support?
It already has, supported by every browser, also supported by Node - but we need to upgrade to LTS Node version 22.
Also: We already polyfill this for Nextcloud server, so the only problem here are the tests.
Image preloading should be rate limited, to not overload the server. Now it is set to max. 5 requests at the same time. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/rate-limit-previews
branch
from
9d8265d to
5cfd115
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image preloading should be rate limited, to not overload the server. Now it is set to max. 5 requests at the same time.