Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci: add ESLint workflow
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
susnux committed May 12, 2025
commit 684ebe228381b24bfab54c225de48fc0ed89544d
44 changes: 44 additions & 0 deletions .github/workflows/lint-eslint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud-libraries/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT

name: Lint eslint

on: pull_request

permissions:
contents: read

concurrency:
group: lint-eslint-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
lint:
runs-on: ubuntu-latest

name: eslint

steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false

- name: Set up node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version-file: 'package.json'

- name: Install dependencies
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
run: npm ci

- name: Lint
run: npm run lint
3 changes: 2 additions & 1 deletion lib/public-auth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ export type GuestUserPromptOptions = PublicAuthPromptProps
* @return The selected name or undefined if dialog was closed
*/
export async function showGuestUserPrompt(props: GuestUserPromptOptions): Promise<string | undefined> {
const [name] = await spawnDialog(
const name = await spawnDialog(
defineAsyncComponent(() => import('./components/PublicAuthPrompt.vue')),
props,
)
/// @ts-expect-error TODO: remove when fixed upstream: https://github.com/nextcloud-libraries/nextcloud-vue/issues/6902
return name
}
Loading