Skip to content

fix(PublicAuthPrompt): change default notice if identified #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Aug 26, 2025
Merged

fix(PublicAuthPrompt): change default notice if identified #1880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions l10n/messages.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ msgstr ""
msgid "Upload some content or sync with your devices!"
msgstr ""

msgid "You are currently identified as {nickname}."
msgstr ""

msgid "You are currently not identified."
msgstr ""

Expand Down
18 changes: 16 additions & 2 deletions lib/components/PublicAuthPrompt.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export interface PublicAuthPromptProps {

const props = withDefaults(defineProps<PublicAuthPromptProps>(), {
nickname: '',
notice: t('You are currently not identified.'),
notice: '',
submitLabel: t('Submit name'),
text: '',
title: t('Guest identification'),
Expand Down Expand Up @@ -104,6 +104,20 @@ const buttons = computed(() => {
return [submitButton]
})

const defaultNotice = computed(() => {
if (props.notice) {
return props.notice
}

// If no notice is provided, use a default one
// that changes based on the nickname definition
if (name.value) {
return t('You are currently identified as {nickname}.', { nickname: name.value })
}

return t('You are currently not identified.')
})

/**
* Handle saving the nickname and return it.
*/
Expand Down Expand Up @@ -169,7 +183,7 @@ function onSubmit() {
<!-- Header -->
<NcNoteCard
class="public-auth-prompt__header"
:text="notice"
:text="defaultNotice"
type="info" />

<!-- Form -->
Expand Down