-
Notifications
You must be signed in to change notification settings - Fork 5
fix(guestName): limit length to 64 characters #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cd62144 to
9d0220c
Compare
9d0220c to
4801503
Compare
Depending on the database used this will not work, it is only guaranteed to store 64 bytes then. |
Could you point me to the database in question? According to https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/datatype-limits.html oracle does not seem to be an issue:
Same for Postgres: https://www.postgresql.org/docs/10/datatype-character.html
I also checked mysql and mariadb. sqlite does not have limited length data types afaik. |
But this depends on the encoding used on the database which is not always utf8 (see their mysql variants) |
4801503 to
6e98445
Compare
This is the same limit we apply to authenticated user display names. The text app stores guest names in a 64 char database field. Note that this is counting characters - not bytes. So languages with multi-byte characters can still use 64 chars in name. Signed-off-by: Max <[email protected]>
6e98445 to
ab78849
Compare
|
@susnux adjusted according to your proposal. |
|
/backport to stable6 |
This is the same limit we apply to authenticated user display names.
The text app stores guest names in a 64 char database field.
Note that this is counting characters - not bytes.
So languages with multi-byte characters can still use 64 chars in name.