Do not change css class names when building #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <[email protected]>
1 task
Contributor
Author
|
Bump please so we can fix server 😁 |
szaimen
approved these changes
Nov 2, 2022
ChristophWurst
approved these changes
Nov 2, 2022
Contributor
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Mind shedding some light on why esm broke this and how your patch fixes this?
👍 🐘
Contributor
Author
esm is not needed, the #691 was part of the answer on how to properly compile scss with rollup. |
Contributor
|
Ok but I still can't follow. |
Merged
Contributor
Author
This is about the scss->css compilation, no about the js bundles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glad we did some beta lol, it seems module do some weird stuff
Ref nextcloud/server#34868