Fix package resolving in webpack projects #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
mejo-
approved these changes
Feb 16, 2023
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
I can verify that this fixes using @nextcloud/vue 7.6.0.
ChristophWurst
approved these changes
Feb 16, 2023
Contributor
|
Thanks @susnux I'll spin a new release |
Contributor
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the 4.0.0 release can not be used with webpack projects, because they will throw:
ReferenceError: exports is not defined.Webpack tries to resolve the import of
@nextcloud/dialogstonode_modules/@nextcloud/dialogs/dist/index.js.This is a commonjs file, but webpack expects an esm file, so
exportsis not defined.I guess this happens because
dialogshas its type set tomodule´ so every.js` file within will be handled as esm.So to fix this we need to explicitly name commonjs files
.cjs.I noticed this issue when trying to use
@nextcloud/vue 7.6.0which depends on dialogs version4.0.0.