fix(stable4): Revert nextcloud-vue to version 7.12 to support Nextcloud 27 #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
AndyScherzinger,
artonge,
juliusknorr and
skjnldsv
…ud 27 Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/revert-nextcloud-vue-v8-on-stable4
branch
from
98c23b0 to
dc4ce79
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
AndyScherzinger
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Nextcloud 27 and before use nextcloud-vue 7 so for proper support we can not just version 8 in this library as there will be some styling collisions.
So instead lets have a stable4 branch for Nextcloud 27 and below using nextcloud-vue 7 and on master use nextcloud-vue 8 (and set version to dialogs 5.0.0-beta.1).