[stable4] Fix styling issues and make the FilePicker height fixed #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
susnux
commented
Aug 28, 2023
susnux
commented
- backport of Fix styling issues and make the FilePicker height fixed #971
* Make sure scrolled elements can not be seen through the table header * Ensure the buttons are not overlaying the files list content Signed-off-by: Ferdinand Thiessen <[email protected]>
…g skeletons Signed-off-by: Ferdinand Thiessen <[email protected]>
jancborchardt
approved these changes
Aug 30, 2023
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good as per #971 but can not judge the code.
|
@AndyScherzinger @skjnldsv if this is not merged, won't we have a wonky file picker which changes height on navigation? |
AndyScherzinger
approved these changes
Sep 4, 2023
Contributor
|
/l10n-update |
Signed-off-by: nextcloud-command <[email protected]>
Pytal
approved these changes
Sep 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.