feat(node): Add displayname as top level attribute
#1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
type: enhancement
For legacy reasons a fallback is still used to move it from the `attributes` as otherwise this would be breaking. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/add-displayname-as-top-level
branch
from
cd9a785 to
b23901e
Compare
skjnldsv
approved these changes
Jul 18, 2024
Contributor
I'm not a smart man.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.moveshould also adjust the displayname #1018For legacy reasons a fallback is still used to move it from the
attributesas otherwise this would be breaking.