feat: Implement API for file list filters #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
type: enhancement
7 tasks
Bundle ReportChanges will increase total bundle size by 36.44kB ⬆️
|
AndyScherzinger
approved these changes
Jul 24, 2024
susnux
force-pushed
the
feat/file-list-filters
branch
from
ae4d2b5 to
b20b328
Compare
skjnldsv
reviewed
Jul 25, 2024
skjnldsv
reviewed
Jul 25, 2024
skjnldsv
reviewed
Jul 25, 2024
Contributor
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Only issue is the wording of the events :)
Co-authored-by: John Molakvoæ <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/file-list-filters
branch
from
88b03ee to
aeffba3
Compare
skjnldsv
approved these changes
Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API allows to create file list filters.
The basic filter just provides a filter function, while you could also register a visual entry.
I played with custom elements (aka web components) as this is probably the way to go in the future, but with Vue2 it seems to be more complex than I could invest time, so went the legacy way and just add a callback function that gets the root element where to render its component.