Skip to content

feat: Allow views to be naturally sorted #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 1 commit into from
Aug 17, 2024
Merged

feat: Allow views to be naturally sorted #1053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/navigation/view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,12 @@ interface ViewData {
getContents: (path: string) => Promise<ContentsWithRoot>
/** The view icon as an inline svg */
icon: string
/** The view order */
order: number

/**
* The view order.
* If not set will be natural sorted by view name.
*/
order?: number

/**
* Custom params to give to the router on click
Expand Down Expand Up @@ -199,8 +203,8 @@ const isValidView = function(view: ViewData): boolean {
throw new Error('View icon is required and must be a valid svg string')
}

if (!('order' in view) || typeof view.order !== 'number') {
throw new Error('View order is required and must be a number')
if ('order' in view && typeof view.order !== 'number') {
throw new Error('View order must be a number')
}

// Optional properties
Expand Down