Skip to content

fix: ensure FileListAction return bool|null on exec #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Dec 13, 2024
Merged

fix: ensure FileListAction return bool|null on exec #1145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b7985
fix: ensure FileListAction return `bool|null` on `exec`
skjnldsv Dec 12, 2024
cf21206
fix: wording
skjnldsv Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions lib/fileListAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,20 @@ interface FileListActionData {
order: number

/**
* Returns true if this action shoud be shown
*
* Condition whether this action is shown or not
* @param view The current view
* @param nodes The nodes in the current directory
* @param folder The current folder
*/
enabled?: (view: View, nodes: Node[], folder: Folder) => boolean

/**
* Function to execute
*
* @param view The current view
* @param nodes The nodes in the current directory
* @param folder The current folder
* Function executed on single file action
* @return true if the action was executed successfully,
* false otherwise and null if the action is silent/undefined.
* @throws Error if the action failed
*/
exec: (view: View, nodes: Node[], folder: Folder) => Promise<void>
exec: (view: View, nodes: Node[], folder: Folder) => Promise<boolean|null>,
}

export class FileListAction {
Expand Down
Loading