Skip to content

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Nov 25, 2025

EDIT: superseded by #1124

Fix something we should have done since the beginning.

  • Instead of just giving the current dir path, we'll give the full directory object
  • We'll also provide the list of files we currently have in the folder. This will allow apps to more easily do things with it like
    • Conflicts calculations
    • Files browsing (e.g viewer can easily just rely on the current list and be faster)

It also now follows similar approach to the FileListAction

@skjnldsv skjnldsv added this to the v4.0.0 milestone Nov 25, 2025
@skjnldsv skjnldsv self-assigned this Nov 25, 2025
@skjnldsv skjnldsv added type: enhancement 🚀 New feature or request 3. to review 3️⃣ Waiting for reviews type: breaking 💥 changes that require a new major version labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (b552e14) to head (f44df35).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          23       23           
  Lines         670      670           
  Branches      182      182           
=======================================
  Hits          608      608           
  Misses         51       51           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skjnldsv skjnldsv requested review from artonge and susnux November 26, 2025 09:43
Base automatically changed from fix/clone to main November 26, 2025 09:53
@susnux
Copy link
Contributor

susnux commented Nov 26, 2025

Maybe just #1124 ?

@skjnldsv
Copy link
Contributor Author

Maybe just #1124 ?

With how long it staled, I figured maybe it was too complicated ?
Tell me if you think I should revive it 👍

@susnux
Copy link
Contributor

susnux commented Nov 26, 2025

With how long it staled, I figured maybe it was too complicated ?

No I think it was just the v4 thing. But as we going for a v4 that PR looks good to me.
(This one is good as well ;) )

@skjnldsv
Copy link
Contributor Author

But as we going for a v4 that PR looks good to me.
(This one is good as well ;) )

What do you prefer? :)

@susnux
Copy link
Contributor

susnux commented Nov 26, 2025

What do you prefer? :)

The other PR because that allow us to add new context entries if needed without need of more parameters.

@skjnldsv skjnldsv closed this Nov 26, 2025
@skjnldsv skjnldsv deleted the feat/actions-dir-content branch November 27, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: breaking 💥 changes that require a new major version type: enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants