Skip to content

Conversation

@skjnldsv
Copy link
Contributor

Otherwise the file is missing from the dist

@skjnldsv skjnldsv added this to the v4.0.0 milestone Nov 27, 2025
@skjnldsv skjnldsv requested a review from susnux November 27, 2025 08:29
@skjnldsv skjnldsv self-assigned this Nov 27, 2025
@skjnldsv skjnldsv added the 3. to review 3️⃣ Waiting for reviews label Nov 27, 2025
@skjnldsv skjnldsv requested review from ShGKme and artonge November 27, 2025 08:29
@skjnldsv skjnldsv added the type: bug 🐛 Something isn't working label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (894f48b) to head (1ac5c9e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          23       23           
  Lines         666      666           
  Branches      181      181           
=======================================
  Hits          604      604           
  Misses         51       51           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skjnldsv skjnldsv merged commit 848bc59 into main Nov 27, 2025
11 checks passed
@skjnldsv skjnldsv deleted the fix/types-export branch November 27, 2025 09:08
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2025
export * from './newMenu/index.ts'
export * from './node/index.ts'
export * from './permissions.ts'
export * from './types.ts'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe safe guard this

Suggested change
export * from './types.ts'
export type * from './types.ts'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants