Skip to content

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Nov 27, 2025

Renamed content to contents for consistency

@skjnldsv skjnldsv added this to the v4.0.0 milestone Nov 27, 2025
@skjnldsv skjnldsv self-assigned this Nov 27, 2025
@skjnldsv skjnldsv added 3. to review 3️⃣ Waiting for reviews type: refactor ♻️ Refactor code (not a bug fix, not a feature just refactoring) labels Nov 27, 2025
@skjnldsv skjnldsv requested a review from susnux November 27, 2025 14:46
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (621e4a8) to head (1419664).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1386   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          23       23           
  Lines         666      666           
  Branches      181      181           
=======================================
  Hits          604      604           
  Misses         51       51           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

susnux

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the fix/actions-context branch from 2356d0c to 1419664 Compare November 27, 2025 14:59
@skjnldsv skjnldsv changed the title fix(actions): reduce context of displayName, title, iconSvgInline, inline and renderInline fix(actions): rename content to contents Nov 27, 2025
@skjnldsv
Copy link
Contributor Author

Done @susnux

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always confused by the English uncountable vs countable plurals 😅
(for me content sounds right but it seems if you can count the content it becomes contents 🤯 )

@susnux susnux merged commit f442781 into main Nov 27, 2025
11 checks passed
@susnux susnux deleted the fix/actions-context branch November 27, 2025 15:01
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: refactor ♻️ Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants