Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 27, 2025

@susnux susnux requested a review from skjnldsv November 27, 2025 15:37
@susnux susnux added 3. to review 3️⃣ Waiting for reviews type: breaking 💥 changes that require a new major version type: refactor ♻️ Refactor code (not a bug fix, not a feature just refactoring) labels Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (f442781) to head (60fbb21).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
- Coverage   90.69%   90.50%   -0.19%     
==========================================
  Files          23       23              
  Lines         666      653      -13     
  Branches      181      175       -6     
==========================================
- Hits          604      591      -13     
  Misses         51       51              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@susnux susnux force-pushed the refactor/make-root-required branch from 7b5c05e to 60fbb21 Compare November 27, 2025 15:39
@skjnldsv skjnldsv merged commit 1729c40 into main Nov 27, 2025
11 checks passed
@skjnldsv skjnldsv deleted the refactor/make-root-required branch November 27, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: breaking 💥 changes that require a new major version type: refactor ♻️ Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should NodeData.root be a required property?

3 participants