Skip to content

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Sep 8, 2022

Since on the same initiated instance, the context can change, we need a way to filter Entries

e.g.

  1. Open the Files app (the NewFileMenu gets initialized)
  2. See that you can create files
  3. Navigate to a shared read-only folder
  4. The context change, the menu list should be different
  • Feature
  • Testing
  • Removing unnecessary FileType from (unreleased) API.
    It was a leftover from th server API where the api itself was in charge of creating the file/folder. So it needed to know what type it was. But now we let that to the Entry registration via the handler prop.

@skjnldsv skjnldsv added the type: enhancement 🚀 New feature or request label Sep 8, 2022
@skjnldsv skjnldsv requested a review from artonge September 8, 2022 11:48
@skjnldsv skjnldsv self-assigned this Sep 8, 2022
Signed-off-by: John Molakvoæ <[email protected]>
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #484 (2e6ffde) into master (a728c13) will increase coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   75.36%   76.11%   +0.75%     
==========================================
  Files           4        4              
  Lines          69       67       -2     
  Branches       16       16              
==========================================
- Hits           52       51       -1     
+ Misses         15       14       -1     
  Partials        2        2              
Impacted Files Coverage Δ
lib/index.ts 0.00% <ø> (ø)
lib/newFileMenu.ts 96.66% <100.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@skjnldsv skjnldsv merged commit d4f14b0 into master Sep 8, 2022
@skjnldsv skjnldsv deleted the feat/context-menu branch September 8, 2022 12:09
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants