fix: prevent invalid roots to be defined #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
===========================================
- Coverage 100.00% 99.56% -0.44%
===========================================
Files 10 10
Lines 224 232 +8
Branches 62 68 +6
===========================================
+ Hits 224 231 +7
- Misses 0 1 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
skjnldsv
commented
Feb 3, 2023
skjnldsv
force-pushed
the
fix/root-guards
branch
2 times, most recently
from
4ff30d6 to
3f0f97e
Compare
skjnldsv
force-pushed
the
fix/root-guards
branch
from
3f0f97e to
922dcf2
Compare
Pytal
approved these changes
Apr 10, 2023
skjnldsv
force-pushed
the
fix/root-guards
branch
from
922dcf2 to
2aa9658
Compare
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
fix/root-guards
branch
from
2aa9658 to
1e6dab6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit more safeguards and fixes the
pathcomputation that goes with it