Skip to content

feat(actions): also test doc build on pull requests #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 16, 2023
Merged

feat(actions): also test doc build on pull requests #621

skjnldsv merged 1 commit into from
Apr 16, 2023

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Apr 7, 2023 •
edited
Loading

@ChristophWurst do you know why @nextcloud/l10n is failing ?

@skjnldsv skjnldsv self-assigned this Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (97a2aab) 100.00% compared to head (29c0280) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #621   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          242       242           
  Branches        68        68           
=========================================
  Hits           242       242

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@susnux
Copy link
Contributor

susnux commented Apr 16, 2023

@skjnldsv I think because the @nextcloud/typings is not installed. It is just a dev dependency of l10n and no dependency of nextcloud-files.
I think either adding it is as a dev dependency of nextcloud-files or a (peer) dependency of l10n will fix this issue.

@skjnldsv skjnldsv requested a review from susnux April 16, 2023 14:36
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Apr 16, 2023

@susnux well done! 🚀 🙏

@skjnldsv skjnldsv added type: bug 🐛 Something isn't working type: documentation 📖 Improvements or additions to documentation labels Apr 16, 2023
susnux
susnux approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should still add it is as a (peer) dependency to l10n but until then this is fine 👍

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Apr 16, 2023 •
edited
Loading

Probably we should still add it is as a (peer) dependency to l10n but until then this is fine +1

Hum, that's actually more correct. This doesn't belong here ? 🙈
ANyway, let's merge here and open a ticket in @nextcloud/l10n

@skjnldsv skjnldsv merged commit 2114236 into master Apr 16, 2023
@skjnldsv skjnldsv deleted the fix/actions-doc branch April 16, 2023 15:00
@skjnldsv skjnldsv mentioned this pull request Apr 16, 2023
Closed
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

Assignees

@skjnldsv skjnldsv

Labels

type: bug 🐛 Something isn't working type: documentation 📖 Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @susnux