Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/files/file.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('File creation', () => {
expect(file.root).toBe('/files/emma/Photos')
expect(file.path).toBe('/picture.jpg')
expect(file.isDavRessource).toBe(true)
expect(file.permissions).toBe(Permission.READ)
expect(file.permissions).toBe(Permission.NONE)
})

test('Valid dav file with root', () => {
Expand All @@ -59,7 +59,7 @@ describe('File creation', () => {
expect(file.root).toBe('/files/emma')
expect(file.path).toBe('/Photos/picture.jpg')
expect(file.isDavRessource).toBe(true)
expect(file.permissions).toBe(Permission.READ)
expect(file.permissions).toBe(Permission.NONE)
})

test('Valid remote file', () => {
Expand Down
4 changes: 2 additions & 2 deletions __tests__/files/folder.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('Folder creation', () => {
expect(folder.dirname).toBe('/')
expect(folder.root).toBe('/files/emma')
expect(folder.isDavRessource).toBe(true)
expect(folder.permissions).toBe(Permission.READ)
expect(folder.permissions).toBe(Permission.NONE)
})

test('Valid dav folder with root', () => {
Expand All @@ -49,7 +49,7 @@ describe('Folder creation', () => {
expect(folder.dirname).toBe('/Photos')
expect(folder.root).toBe('/files/emma')
expect(folder.isDavRessource).toBe(true)
expect(folder.permissions).toBe(Permission.READ)
expect(folder.permissions).toBe(Permission.NONE)
})

test('Valid remote folder', () => {
Expand Down
21 changes: 21 additions & 0 deletions __tests__/files/node.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { File } from '../../lib/files/file'
import { Folder } from '../../lib/files/folder'
import NodeData, { Attribute } from '../../lib/files/nodeData'
import { Permission } from '../../lib/permissions'

describe('Node testing', () => {
test('Root null fallback', () => {
Expand Down Expand Up @@ -229,6 +230,26 @@ describe('Dav service detection', () => {
})
})

describe('Permissions handling', () => {
test('Default permissions', () => {
const file = new File({
source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/picture.jpg',
mime: 'image/jpeg',
owner: 'emma',
})
expect(file.permissions).toBe(0)
})

test('Custom permissions', () => {
const file = new File({
source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/picture.jpg',
mime: 'image/jpeg',
owner: 'emma',
permissions: Permission.READ | Permission.UPDATE | Permission.CREATE | Permission.DELETE | Permission.SHARE,
})
expect(file.permissions).toBe(31)
})
})

describe('Root and paths detection', () => {
test('Unknown root', () => {
Expand Down
5 changes: 4 additions & 1 deletion lib/files/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,10 @@ export abstract class Node {
return Permission.READ
}

return this._data.permissions || Permission.READ
// If the permissions are not defined, we have none
return this._data.permissions !== undefined
? this._data.permissions
: Permission.NONE
}

/**
Expand Down