fix(dav): Fix DAV functions to make work with them easier

[susnux]

• davGetClient should default to the DAV remote URL instead of including the users root (to allow SEARCH)
• getFavoriteNodes should work with any path
• Add missing documentation

Because especially the getFavoriteNodes function was copied from the files app, but there is no reason why it should be restricted in this library to only support favorites on / but not on other paths (also the documentation said it would do).

[codecov]

Codecov Report

Merging #725 (d33096d) into master (cd35f80) will decrease coverage by 0.26%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   78.20%   77.94%   -0.26%     
==========================================
  Files          17       17              
  Lines         390      390              
  Branches      109      107       -2     
==========================================
- Hits          305      304       -1     
- Misses         72       73       +1     
  Partials       13       13              

Files Changed	Coverage Δ
lib/dav/dav.ts	53.84% <87.50%> (-3.85%)	⬇️

[skjnldsv]

Hummmm, this is a breaking change though.
I need to have a clear mind to think about this, too blurry today :)

[susnux]

@skjnldsv basically every beta version currently was breaking ;-)

There are two breaking changes here:

1. Make get favorites do what the documentation of it says instead of returning all files for non root
2. Change the root and remote URL constants, our documentation about the DAV endpoint in the developer docs says we always use the .../dav/ endpoint all API requests so we should provide this remote path and only append the users root is needed (e.g. requesting directory content).

[skjnldsv]

basically every beta version currently was breaking ;-)

yes and no.
But right now we change the entire logic of the dav protocol.

What is the migration path for this change?

[susnux]

What is the migration path for this change?

Not much needed, querying favorites should work as before as the root is injected.
Only if you use the provided client you will have to make sure to use ${davRootPath}${path} for e.g. getDirectoryContent.

The client now is configured with the base url as in our documentation: https://docs.nextcloud.com/server/latest/developer_manual/client_apis/WebDAV/basic.html#webdav-basics