Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 23, 2023

No description provided.

@susnux susnux requested a review from skjnldsv August 23, 2023 14:57
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise !

susnux and others added 2 commits August 23, 2023 17:19
…not double include in node source

Co-authored-by: John Molakvoæ <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/result-to-node branch from f7a7d21 to 352b98b Compare August 23, 2023 15:19
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #741 (352b98b) into master (ab973d7) will increase coverage by 0.50%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   77.15%   77.66%   +0.50%     
==========================================
  Files          17       17              
  Lines         394      394              
  Branches      107      107              
==========================================
+ Hits          304      306       +2     
+ Misses         77       76       -1     
+ Partials       13       12       -1     
Files Changed Coverage Δ
lib/dav/dav.ts 61.53% <33.33%> (+7.69%) ⬆️

@skjnldsv skjnldsv merged commit 4b8ab1e into master Aug 23, 2023
@skjnldsv skjnldsv deleted the fix/result-to-node branch August 23, 2023 15:59
@skjnldsv skjnldsv added type: bug 🐛 Something isn't working 3. to review 3️⃣ Waiting for reviews labels Aug 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants