fix: use Node and not string for the new file menu handler arg #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
added
type: bug
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 17 17
Lines 403 403
Branches 108 108
=======================================
Hits 311 311
Misses 91 91
Partials 1 1
|
juliusknorr
approved these changes
Aug 30, 2023
Contributor
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Makes much more senes 🙈
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How else are we gonna get the mtime or size.... 🙈