fix!(humanFileSize): Revert changes to default file sizes #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sizes but decimal units) For Nextcloud the current default is using binary sizes, like 1024 or 2048, but showing decimal units. Meaning 1024 bytes = 1 KB, like done on Windows and not like on Linux 1024 bytes = 1 KiB. There is also the option to show like on Apple: 1000 bytes = 1 KB and 1024 bytes = 1.024 KB Signed-off-by: Ferdinand Thiessen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 78.01% 78.06% +0.05%
==========================================
Files 17 17
Lines 423 424 +1
Branches 112 113 +1
==========================================
+ Hits 330 331 +1
Misses 93 93
|
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(use binary sizes but decimal units)
For Nextcloud the current default is using binary sizes, like 1024 or 2048, but showing decimal units. Meaning 1024 bytes = 1 KB, like done on Windows and not like on Linux 1024 bytes = 1 KiB. There is also the option to show like on Apple: 1000 bytes = 1 KB and 1024 bytes = 1.024 KB
This is (again) breaking