fix(node): remove auto mtime update on attributes change and allow mtime set #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime set Signed-off-by: skjnldsv <[email protected]>
Bundle ReportChanges will decrease total bundle size by 134 bytes ⬇️
|
susnux
approved these changes
Jun 4, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Makes sense!
Do you think we should make updateMTime public for convenience?
Contributor
Author
doesn't hurt, but not sure it's really necessary 🤔 |
Signed-off-by: skjnldsv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextcloud/server#45656 (review)
Supersede #973