Decode html characters

[julien-nc]

When a placeholder contains characters like ' " < >, they are replaced by their HTML code. This leads to this kind of issues:
Fix nextcloud/server#26113

Would it be a good solution to decode them here?

[ChristophWurst]

sounds like a bad idea. you can achieve the same with options.sanitize=false

[julien-nc]

@ChristophWurst Thanks, that's what I was looking for.

Do you mean on some translate and translatePlural calls, when we know those characters are potentially there?
Or do you mean adding this option here in translate and translatePlural definitions?

I tried it but I'm still getting the HTML char codes for placeholders substitutions.

t('app', 'Hello {name}', { name: 'O\'Brian' }, {}, null, { sanitize: false })

returns Hello O'Brian

[ChristophWurst]

I tried it but I'm still getting the HTML char codes for placeholders substitutions.

t('app', 'Hello {name}', { name: 'O\'Brian' }, {}, null, { sanitize: false })

There is also options.escape

[julien-nc]

t('app', 'Hello {name}', { name: 'O\'Brian' }, {}, null, { sanitize: false, escape: false })

still returns Hello O'Brian 🤔

[skjnldsv]

still returns Hello O'Brian

Make sure you're properly using the method from @nextcloud/l10n and not window.t 🤔

[szaimen]

Any update here?

[julien-nc]

@skjnldsv @ChristophWurst Using @nextcloud/l10n@^1.4.1:

import { translate } from '@nextcloud/l10n'
console.debug(translate('app', 'Hello {name}', { name: 'O\'Brian' }, {}, null, { sanitize: false, escape: false }))
// => Hello O'Brian
console.debug(window.t('app', 'Hello {name}', { name: 'O\'Brian' }, {}, null, { sanitize: false, escape: false }))
// => Hello O'Brian

[julien-nc]

Sorry for the noise. There are too many parameters passed in the examples I gave. All good.

[szaimen]

@eneiluj will nextcloud/server#26113 not be fixed then?

[julien-nc]

@szaimen Yes, thanks for reminding me: nextcloud/server#27912