Do not require the OC variable to be set
#362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the library more robust against loading order problems and reduces problems with testing setups. Signed-off-by: Ferdinand Thiessen <[email protected]>
skjnldsv
approved these changes
Jul 7, 2022
Contributor
|
Please let's make sure to deprecate 2.2.0 on npm afterwards please |
Contributor
Contributor
Deprecate? |
Contributor
|
If you think it's the right thing to do then go ahead :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #361
This makes the library more robust against loading order problems
and reduces problems with testing setups.