Skip to content

Commit 1db8eaf

Browse files
authored
Merge pull request #1000 from nextcloud-libraries/chore/vue-2-compatibility
chore: move vue dependencies to plain dependencies
2 parents 9cb6c80 + 0fd35d9 commit 1db8eaf

File tree

5 files changed

+68
-188
lines changed

5 files changed

+68
-188
lines changed

.github/dependabot.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ updates:
3333
time: "03:00"
3434
timezone: Europe/Paris
3535
versioning-strategy: increase
36-
open-pull-requests-limit:
36+
open-pull-requests-limit: 10
3737
ignore:
3838
# no major updates on stable branches
3939
- dependency-name: "*"

CHANGELOG.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,31 @@ All notable changes to this project will be documented in this file.
66
- SPDX-License-Identifier: MIT
77
-->
88

9+
## 6.0.0 - UNRELEASED
10+
### Notes
11+
12+
This package now builds on top of `@nextcloud/vue` version 9 using Vue 3.
13+
While this package uses Vue 3 it is also possible to use it within a Vue 2 project,
14+
in this case the Vue dependency will not be shared as the dependency was moved from a peer dependency to a plain dependency.
15+
This also means that if you are using Vue 2 you have to ensure you do not use bundler
16+
configurations that enforce resolving Vue to the same version as this will fail now,
17+
instead let the bundler choose the matching Vue version.
18+
19+
For example if using Webpack this will no longer work in **Vue 2** apps:
20+
```js
21+
resolve: {
22+
alias: {
23+
vue$: path.resolve('./node_modules/vue'),
24+
},
25+
}
26+
```
27+
28+
For Vue 3 apps nothing changed, meaning the app and this library will share the same Vue dependency as long as the versions are compatible.
29+
30+
### Breaking
31+
32+
* This package now uses Vue 3 internally.
33+
934
## 5.3.1 - 2024-12-16
1035

1136
### What's Changed

README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,16 @@ This library exports a function that displays a password confirmation dialog whe
1818

1919
| `@nextcloud/password-confirmation` | Maintained | Nextcloud | `@nextcloud/vue` |
2020
| ---------------------------------- | ---------- | ----------- | ---------------- |
21-
| 6.x || 30+ | 9.x (Vue 3) |
21+
| 6.x || 30+ | *9.x (Vue 3)* ¹ |
2222
| 5.x || 28-31 | 8.x |
2323
| 2.x - 4.x || 25-27 | 7.x |
2424
| 1.x || < 25 | - |
2525

26+
¹: In version 6.x the `@nextcloud/vue` dependency is moved to `dependencies` so you can also use this library
27+
with an old version of `@nextcloud/vue` in your app dependencies if your app still uses Vue 2.
28+
Note that this might increase the bundled app size.
29+
If your app also already uses `@nextcloud/vue` version 9.x and Vue 3 then the bundle size will not increase.
30+
2631
## Installation
2732
```sh
2833
npm install @nextcloud/password-confirmation

0 commit comments

Comments
 (0)