chore: move vue dependencies to plain dependencies #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
approved these changes
May 9, 2025
Contributor
There was a problem hiding this comment.
I tested two Vue 2 apps using the shared webpack config. I had to add the following line to webpack.config.js to make it work:
// Allow two versions of Vue to make @nextcloud/password-confirmation work
delete webpackConfig.resolve.alias.vue$I couldn't spot a significant difference in bundle size 🤷♂️
ShGKme
approved these changes
May 9, 2025
This allows in theory (tested) to also use this library with Vue 2 apps. For those the bundle size will increase as Vue needs to bundled two times, but if you use Vue 3 all works as intended (only bundled once so small asset size). This allows us to drop maintenance on v5 as soon as Nextcloud 31 gets EOL. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/vue-2-compatibility
branch
from
0d01063 to
458eff9
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows in theory (tested) to also use this library with Vue 2 apps. For those the bundle size will increase as Vue needs to bundled two times, but if you use Vue 3 all works as intended (only bundled once so small asset size).
This allows us to drop maintenance on v5 as soon as Nextcloud 31 gets EOL.