Skip to content

fix(UploadPicker): Add label for upload progress and connect progress with description [a11y] #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Dec 15, 2023
Merged

fix(UploadPicker): Add label for upload progress and connect progress with description [a11y] #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(UploadPicker): Add label for upload progress and connect progress… 
… with description

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Dec 14, 2023
commit 144c40d1304a4758f8d07198de598cdeafb105de
3 changes: 3 additions & 0 deletions l10n/messages.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ msgstr ""
msgid "Upload files"
msgstr ""

msgid "Upload progress"
msgstr ""

msgid "Which files do you want to keep?"
msgstr ""

Expand Down
12 changes: 8 additions & 4 deletions lib/components/UploadPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,14 @@
</NcActionButton>
</NcActions>

<!-- Progressbar and status, hidden by css -->
<div class="upload-picker__progress">
<NcProgressBar :error="hasFailure"
<!-- Progressbar and status -->
<div v-show="isUploading" class="upload-picker__progress">
<NcProgressBar :aria-label="progressLabel"
:aria-describedby="progressTimeId"
:error="hasFailure"
:value="progress"
size="medium" />
<p>{{ timeLeft }}</p>
<p :id="progressTimeId">{{ timeLeft }}</p>
</div>

<!-- Cancel upload button -->
Expand Down Expand Up @@ -146,6 +148,8 @@ export default Vue.extend({
addLabel: t('New'),
cancelLabel: t('Cancel uploads'),
uploadLabel: t('Upload files'),
progressLabel: t('Upload progress'),
progressTimeId: `nc-uploader-progress-${Math.random().toString(36).slice(7)}`,

eta: null,
timeLeft: '',
Expand Down