Skip to content

fix(uploader): properly propagate upload cancelled status #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 1 commit into from
Feb 25, 2025
Merged

fix(uploader): properly propagate upload cancelled status #1617

susnux merged 1 commit into from
Feb 25, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Feb 25, 2025

To reproduce:

  1. Upload a file which already exists
  2. Cancel
  3. See the progress still visible
  4. See error saying something went wrong (but it didn't, the user cancelled on purpose)

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Feb 25, 2025
@susnux susnux requested a review from skjnldsv February 25, 2025 13:14
skjnldsv
skjnldsv reviewed Feb 25, 2025
View reviewed changes
@susnux susnux force-pushed the fix/upload-cancelled branch from 0b53e8f to 21b6756 Compare February 25, 2025 13:38
@susnux susnux merged commit d4c7eb8 into main Feb 25, 2025
21 checks passed
@susnux susnux deleted the fix/upload-cancelled branch February 25, 2025 13:42
@skjnldsv skjnldsv mentioned this pull request Mar 4, 2025
Merged
@susnux susnux mentioned this pull request Mar 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Progress bar remains stuck on screen after ignoring files in the conflicts modal

3 participants

@susnux @skjnldsv