-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: split vue and dialogs sub modules to prepare for library splitting
#1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
core, ui, components sub-folderscore, ui and components sub modules to prepare for library splitting
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Makes sense in v1. |
Why do we need it? The only purpose of the PR is to prepare for v2. |
Because there will be only the |
I don't understand it in the context of "And if we revert, then it's complicated again to move these parts out from the library again.". And yes, only the core part is left. That is the purpose of the PR, why is it a problem that requires revert to the mixed state? With the refactoring there are 3 separated parts. 2/3 can be easily removed, without any changes in the remaining one. Without it, we have mixed modules using each other, including different parts sometimes in a single file. The only purpose of the PR is to go to v2. If v2 requires reverting the "prepare for v2", when we should close it. |
|
Or the only problem is that the "core" as a folder exists without other folders? If that is the case, we can just move its content to the parent. |
388185f to
df1f5d1
Compare
|
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
df1f5d1 to
62ead94
Compare
core, ui and components sub modules to prepare for library splittingvue and dialogs sub modules to prepare for library splitting
@nextcloud/uploadhas mixed pure API, ui functions (dialogs) and a vue component.- pure uploading logic, kept in placedialogs- UI related functions that use Vue only internally and will be moved to@nextcloud/dialogsin the next majorvue- exported Vue component (that can only be used in a specific Vue version and will be moved to@nextcloud/vuein the next major)Detailed explanation
Details