Skip to content

feat!: keep only pure uploading API and remove Vue parts #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShGKme merged 9 commits into from
Jul 1, 2025
Merged

feat!: keep only pure uploading API and remove Vue parts #1818

ShGKme merged 9 commits into from
Jul 1, 2025

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 27, 2025

💥 BREAKING CHANGES

This library is now a pure uploading API library and no longer contains Vue-related functions and components.

  • UploadPicker Vue component will be available in @nextcloud/vue
  • openConflictPicker and uploadConflictHandler will be available in @nextcloud/dialogs

ShGKme added 8 commits June 27, 2025 15:12
@ShGKme
feat!: remove vue components and dialogs
a877dda 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore(deps): remove vue related deps
1301af3 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore: remove unit tests for dialogs
aca4249 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore: remove cypress
53b98e9 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore(dev-deps): remove Cypress
c6f2441 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore: do not extend @vue/tsconfig
1797eff 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore(dev-deps): remove @vue/tsconfig
9305d47 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
chore: add breaking changes notes for v2
1ae4e80 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme requested review from Antreesy, skjnldsv and susnux June 27, 2025 13:18
@ShGKme ShGKme self-assigned this Jun 27, 2025
@ShGKme ShGKme added 3. to review Waiting for reviews breaking labels Jun 27, 2025
@ShGKme
chore(l10n): extract
91feba4 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Antreesy
Antreesy approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can upload on Vue3 🚀

skjnldsv
skjnldsv approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crying.gif

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 27, 2025

We don't eliminate it, only moving from one place to another 👀

@skjnldsv
Copy link
Contributor

skjnldsv commented Jun 28, 2025

We don't eliminate it, only moving from one place to another 👀

I saw, I was just making a joke 😁

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 30, 2025 •
edited
Loading

@susnux Do you want to have a look at it, or I merge? :)

@ShGKme ShGKme mentioned this pull request Jul 1, 2025
Merged
@ShGKme ShGKme merged commit f2161e7 into next Jul 1, 2025
15 checks passed
@ShGKme ShGKme deleted the feat/keep-only-pure-api branch July 1, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels

3. to review Waiting for reviews breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShGKme @skjnldsv @susnux @Antreesy