Skip to content

Conversation

@joj0r
Copy link
Contributor

@joj0r joj0r commented Aug 4, 2025

Resolves: nextcloud/server#53991

Summary

To be able to resolve nextcloud/server#53991 regarding breakpoints in the files app I have added a prop noLabel on the UploadPicker component to disable the label on breakpoint changes.
This change is required for this PR in nextcloud/server: nextcloud/server#54235

With label:
image

Without label:
image

Checklist

@joj0r joj0r force-pushed the feat/add-option-to-disable-label branch from 2786810 to 0318ca0 Compare August 4, 2025 12:22
@susnux susnux requested a review from skjnldsv August 4, 2025 17:41
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Aug 4, 2025
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.05%. Comparing base (6afe990) to head (2ac95f5).
⚠️ Report is 391 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
+ Coverage   28.58%   36.05%   +7.46%     
==========================================
  Files          14       20       +6     
  Lines        1543     1742     +199     
  Branches       49       83      +34     
==========================================
+ Hits          441      628     +187     
- Misses       1102     1114      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joj0r joj0r force-pushed the feat/add-option-to-disable-label branch from 69073ab to 21058b4 Compare August 6, 2025 11:52
@joj0r joj0r force-pushed the feat/add-option-to-disable-label branch from 21058b4 to 2ac95f5 Compare August 6, 2025 11:54
@susnux susnux merged commit 704929d into nextcloud-libraries:main Aug 6, 2025
14 of 16 checks passed
@susnux susnux mentioned this pull request Sep 10, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Nov 17, 2025

Note for myself: backport to next is not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breakpoint improvements

4 participants