Skip to content

fix(upload): attach response to failed uploads too #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Nov 9, 2023
Merged

fix(upload): attach response to failed uploads too #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/uploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CanceledError } from 'axios'
import { CanceledError, type AxiosError, type AxiosResponse } from 'axios'
import { generateRemoteUrl } from '@nextcloud/router'
import { getCurrentUser } from '@nextcloud/auth'
import { Folder, Permission } from '@nextcloud/files'
Expand Down Expand Up @@ -295,6 +295,12 @@ export class Uploader {
reject('Upload has been cancelled')
return
}

// Attach response to the upload object
if ((error as AxiosError)?.response) {
upload.response = (error as AxiosError).response as AxiosResponse
}

upload.status = UploadStatus.FAILED
logger.error(`Failed uploading ${file.name}`, { error, file, upload })
reject('Failed uploading the file')
Expand Down